Low-provenance Expr->SyntaxTree conversion
#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c42f
force-pushed
the
caf/juliasyntax-dev-fixes
branch
from
63aa9b2 to
3514388
Compare
mlechu
force-pushed
the
ec/expr-to-st
branch
2 times, most recently
from
b678eef to
7cf9664
Compare
mlechu
force-pushed
the
ec/expr-to-st
branch
2 times, most recently
from
f5da731 to
a3b60ed
Compare
c42f
reviewed
Aug 14, 2025
There was a problem hiding this comment.
Looks great. There's a few things which can be refined (such as replacing @assert with something more graceful) but those can be done later.
One thing I noticed is that we need special provenance rules for Expr(:function) - the first LineNumberNode in the body block is the location where the function was defined. So function foo() end has provenance even though there's no place in the :function Expr for the line number. This is how Base.functionloc() works.
Also, could do with some light tests that basic line number provenance is working.
6 tasks
c42f
reviewed
Aug 15, 2025
Avoid overlap with bitwise NOT
Co-authored-by: Claire Foster <[email protected]>
c42f
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main part of #17:
TODO: This will need updates whenever we start using the latest dev version of JuliaSyntax